use prettyname_regex to show shortname in update menu #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% happy about this but it does work. It does it in a workaround way though
Instead of tracking the object all the way through it first uses the regex on the filenames to get the short filenames, then when one of the short filenames is chosen it takes that short name and scans the list of long filenames to find a match, which may not be 100%. We have set filenames though and it shouldn't be a problem I don't think.
This was the only way I could think of doing it because
self.struct['update']['settings']['Build']['values']
needs to be a list, so I cannot pass a dict to it to track a prettyname and a filename for one object.@MilhouseVH please include this in your testbuilds, it will work for you already because you include
prettyname_regex
already in your releases.json