Add (and display) pretty names in release order - not name order #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than sort the list of available builds by the displayed name, we should sort the available builds by the reverse order in which they appear in the
releases.json
file (ie. n, n-1, n-2, ... 0).This PR prevents a build such as
#0101
(from 2017) being listed last in the list and#1231
(from 2016) being listed first, which happens because we are sorting the list into reverse sort order based on the displayed list value -#0101
is a more recent build than#1231
, and should be listed first.In
releases.json
we have:Sorting by the key (0, 1, 267, 268 etc.) as we process the items in
releases.json
, and then displaying the processed items in the default order, ensures the displayed list is in the correct order regardless of what pretty name is displayed.With this change...
Update Channel: Milhouse-8.0 (latest release:
#0101
):Update Channel: LibreELEC-8.0:
Update Channel: LibreELEC-7.0: