connections: fix layout as some icons were off screen

[lrusak]

This is much better. If someone would like me to move things around more let me know.

before:

after:

[MilhouseVH]

Looks good!

Having just reviewed the code for the Connections list from what I see it appears we don't have an "unlocked padlock" security icon for insecure connections - would it be a good idea to add that, otherwise I think we'll just show no security icon at all (which isn't terribly helpful if it's the only connection and/or the user isn't familiar with the security icons that can be shown for a WiFi connection).

Not related to the connections, but @chewitt pointed out the main menu items are not centred vertically - for example, the highlighted Connections menu entry in the screenshots above is vertically positioned slightly above centre.

[MilhouseVH]

Thanks for making these changes, although the Unlock.png icon doesn't exist so will need to be created. There's plenty of space to the right of the padlock so having the unlocked shackle overhang the right side of the padlock body might work.

[lrusak]

@MilhouseVH thanks

I've added a couple commits

here is the menu alignment now and the lock/unlock symbol (currently waiting for unlock photo to be made):

PS. the lock/unlock doesn't seem like it was ever working right, because the object is passed as an array. ie: ['none'] or ['psk', 'wps'] so no matter what the length would evaluate to 1 or more.

to verify please test this simple script
http://sprunge.us/HXMD
note that you may have to scan wifi first
connmanctl scan wifi

output should be like

/net/connman/service/ethernet_b827eb8359d8_cable
[]

/net/connman/service/wifi_98ded015090f_5269636b746f62792d322e3447_managed_psk
[dbus.String(u'psk'), dbus.String(u'wps')]

/net/connman/service/wifi_98ded015090f_534841572d454639343430_managed_psk
[dbus.String(u'psk')]

/net/connman/service/wifi_98ded015090f_696d796f75727a65726f_managed_none
[dbus.String(u'none')]

[lrusak]

pushed a fixup, this is how it looks now

might still want to fix the unlock.png a slight bit so the alignment is perfect

[lrusak]

current look with fixed up icons from @chewitt

[MilhouseVH]

This test isn't working as intended - it will only return true for psk:

result=['ieee8021x','wep']
if ('psk' or 'wep' or 'ieee8021x') in result:
  print("yes")
else:
  print("no")

will print no

[MilhouseVH]

Perfect! :)