Add Names for Gigabyte B660M_DS3H_AX_DDR4 #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
priyanshuagrawal
commented
May 12, 2023
priyanshuagrawal
commented
|
|
PhyxionNL
reviewed
May 12, 2023
| @@ -1618,6 +1618,31 @@ private static void GetIteConfigurationsB(ISuperIO superIO, Manufacturer manufac | |||
|
|
|||
| break; | |||
|
|
|||
| case Model.B660M_DS3H_AX_DDR4: | |||
There was a problem hiding this comment.
Just going to comment on this line, but it applies to all names below. Please follow the naming of the rest in this file. Examples: Vcore instead of VCore. DIMM AB instead of DRAM CH(A/B). System Fan #1 instead of System 1, etc, etc.
There was a problem hiding this comment.
Also you need to add parsing of B660M_DS3H_AX_DDR4 to this file: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/master/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs
There was a problem hiding this comment.
Is there anything more i need to add?
ImLp
pushed a commit
to ImLp/LibreHardwareMonitor
that referenced
this pull request
May 19, 2023
PR LibreHardwareMonitor#1076 incorrectly introduced a build break due to wrong placement of parenthesis. Contributor doesn't appear to have compiled the code.
PhyxionNL
pushed a commit
that referenced
this pull request
May 20, 2023
lavellse
pushed a commit
to lavellse/LibreHardwareMonitor
that referenced
this pull request
Sep 10, 2023
* Add Names for Gigabyte B660M_DS3H_AX_DDR4 * Updated naming, added parsing
lavellse
pushed a commit
to lavellse/LibreHardwareMonitor
that referenced
this pull request
Sep 10, 2023
…1079) PR LibreHardwareMonitor#1076 incorrectly introduced a build break due to wrong placement of parenthesis. Contributor doesn't appear to have compiled the code. Co-authored-by: ImLp <info@luisplacid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.