fix issue preventing control of fans on kraken 2023 #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new Krakens 2023 have a slightly different header when setting fan speed: - when setting fan speed byte 3 and 4 must be `0x1 0x1` instead of `0x0 0x0` - when setting pump speed byte 3 and 4 must be `0x1 0x0` instead of `0x0 0x0` (but even `0x0 0x0`) works for some reason
|
@PhyxionNL : this weirdness in new kraken AIO was not identified in my initial testing (as i did not have an actual fan connected) and the pump speed control was working |
|
@brokenmass some null ref: |
|
@Rem0o could be caused by some other app (NZXT CAM) being open. it should definetely fail better though |
|
Should be fixed by f1a7bb7. |
lavellse
pushed a commit
to lavellse/LibreHardwareMonitor
that referenced
this pull request
Sep 10, 2023
…itor#1085) new Krakens 2023 have a slightly different header when setting fan speed: - when setting fan speed byte 3 and 4 must be `0x1 0x1` instead of `0x0 0x0` - when setting pump speed byte 3 and 4 must be `0x1 0x0` instead of `0x0 0x0` (but even `0x0 0x0`) works for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Krakens 2023 have a slightly different header
when setting fan speed:
0x1 0x1instead of0x0 0x00x1 0x0instead of0x0 0x0(but even0x0 0x0) works for some reason