-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Razer PWM PC Fan Controller #1090
Conversation
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Yea, now its works fine, but I can't test it on newer FanControl versions. |
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things, thanks 😎
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerGroup.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
LibreHardwareMonitorLib/Hardware/Controller/Razer/RazerFanController.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
I don't know, how to hide the device if it disconnected. Is it possible? |
You can choose not to add the device in the group when it's disconnected. For dynamic add/remove you need to implement IHardwareChanged, see an example: For HidSharp I think you can use their Changed event: |
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Ok, maybe I will try to add that |
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Signed-off-by: wlkmanist <vlad.king5555@mail.ru>
Do you still want to do this? |
Probably not, or much later, maybe with another PR. This is not a device that user must plug/unplug while pc is enabled. |
I am on Win8.1, so I can't use Synapse 3 (latest versions that supports this controller) and can't write a plugin for FanControl (V63 is the latest working version for me, with LHM lib 0.8.7). But I can backport this code to 0.8.7 or use it as is.
Controls works in full range (from 0% to 100%). Also already fixed issue with fan hotplug.