Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix it8665e control fans #1109

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

tekert
Copy link
Contributor

@tekert tekert commented Jun 29, 2023

Fix for #1104

Need review, can't test it right now but it should work.

@tekert tekert changed the title Fix it8665e fans Fix it8665e control fans Jun 29, 2023
@PhyxionNL
Copy link
Collaborator

Have you tested it yet?

@tekert
Copy link
Contributor Author

tekert commented Jul 29, 2023

It compiles and can get the data for my needs, but whatever software this is used, no, dind't test other software that uses fan control, according to the reports this should work 100%.

There was some weird coding before my commit 40f225d
as you can see on the left side at line 540, inside the case for motherboards _Model.PRIME_X370_PRO_ and _Model.TUF_X470_PLUS_GAMING_ the Fan Controls where missing already, but this was never a problem because the config for these motherboards where talken in GetIteConfigurationsB and the default case was used, who had fan controls.
When moving the motherboard to the correct place "as is" (only tweaking the names since i have the PRIME PRO), seems it wroke some fan control software, a user pointed out the controls where missing, it should work.
We have to ask the users of the fan control software.

@PhyxionNL PhyxionNL merged commit c51381b into LibreHardwareMonitor:master Aug 20, 2023
1 check passed
@tekert tekert deleted the fix_IT8665E_fans branch August 22, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants