Add NZXT kraken X (X42, X52, X62 or X72) Support #1119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be integrated into KrakenV3? Just glancing over it, and it seems a lot of code is quite similar. |
|
It could, but the sensor reading is quite different and I thought that would add many conditions and obfuscate the code. And also I did not want to break anything as I cannot test on V3 hardware. |
PhyxionNL
requested changes
Aug 20, 2023
| stream.Read(_rawData); | ||
|
|
||
| // if not 0x04, it is not temperature data | ||
| if (_rawData[0] != 0x04) return; |
There was a problem hiding this comment.
Can you reformat this document and follow code style (e.g. return on new line).
| @@ -411,6 +411,8 @@ public static Model GetModel(string name) | |||
| return Model.B660M_DS3H_AX_DDR4; | |||
| case var _ when name.Equals("ROG STRIX Z790-I GAMING WIFI", StringComparison.OrdinalIgnoreCase): | |||
| return Model.ROG_STRIX_Z790_I_GAMING_WIFI; | |||
| case var _ when name.Equals("MPG X570 GAMING PLUS (MS-7C37)",StringComparison.OrdinalIgnoreCase): | |||
There was a problem hiding this comment.
Please move this added motherboard to a separate PR.
There was a problem hiding this comment.
oups, sorry about that it was not supposed to be here
|
sorry did PR on wrong branch, done a new one : #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tested on Kraken X62 Firmware 6.2 should fix #1095