Attached plot panel fixed width plot or sensor panel #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow title case names like the other menu items. I also think it can be renamed to Plot Scaling Mode. |
Edited the names of menu items added for split panel scaling options. Corrected some variable names to corrospond to menu item name changes.
|
Thanks for the feedback. I fixed the title case names. I changed the name to Split Panel Scaling Mode instead of Plot Scaling Mode does that work? The scaling only works if there are two panels in one window. Naming it Plot panel scaling mode might cause people to think that it has something to do with the scaling for the separate plot window as well. |
|
Makes sense, thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scaling the window and the plot panel is attached to the window the width of both panels scale procentualy.
I always use this program with the plot panel attached to the right. I want the sensor panel to have a fixed width so I can freely change the size of the window without having to adjust the width of the sensor panel every time.
In my first commit, I made changes to make it work the way I want it to. But I am not sure everyone agrees with that. In the second commit I added it to the settings and the menu so its optional. the settings also work for when the plot panel is attached to the bottom.
2023-10-12_19-25_6kZXd5uRS3.mp4