Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for NCT6687D #288

Merged
merged 4 commits into from Aug 26, 2020
Merged

Added support for NCT6687D #288

merged 4 commits into from Aug 26, 2020

Conversation

lich426
Copy link
Contributor

@lich426 lich426 commented Aug 1, 2020

I have a MSI Z490 UNIFY
the super io chip on this board is NCT6687D
most msi z490 boards use this chip

LibreHardwareMonitor.Report.txt

111

@PhyxionNL
Copy link
Collaborator

Nice work, would it be possible to merge this into the existing Nct677X class? Quite a lot seems broadly the same. Even though Nct677X doesn't catch the name anymore (it didn't already as also other versions are included).

@lich426
Copy link
Contributor Author

lich426 commented Aug 2, 2020

I merged it with Nct677X class.
but, there seems to be a problem with the file encoding.

@PhyxionNL
Copy link
Collaborator

I merged it with Nct677X class.
but, there seems to be a problem with the file encoding.

I think you'll need to save it as UTF8, or you can try to restore the ö in the file manually. The rest seems the same encoding wise.

@lich426
Copy link
Contributor Author

lich426 commented Aug 2, 2020

I modified the file :)

@likeafox
Copy link

Hello, I am trying to understand your code here. You have Sleep after each device write like for example in SetControl():

WriteByte(_fanControlManualModeRegister, mode);
WriteByte(_fanControlRequestRegister, _fanControlRequestStartCommand);

// need sleep
Thread.Sleep(100);

Why is the Sleep necessary, and how did you learn that the Sleep is necessary?

Also can you tell me how you found the addresses of the registers? I am trying to find documentation. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants