Calculate voltages for Asus ROG Strix B550-F Gaming Wifi motherboard. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhyxionNL
reviewed
Jul 15, 2021
Comment on lines
2386
to
2391
| t.Add(new Temperature("Temperature #1", 1)); | ||
| t.Add(new Temperature("Temperature #2", 2)); | ||
| t.Add(new Temperature("Temperature #3", 3)); | ||
| t.Add(new Temperature("Temperature #4", 4)); | ||
| t.Add(new Temperature("Temperature #5", 5)); | ||
| t.Add(new Temperature("Temperature #6", 6)); |
There was a problem hiding this comment.
Are any of these number temperatures used? Otherwise you can slash them out.
There was a problem hiding this comment.
@volfyd Can you let me know?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared the voltages from ASUS's Armoury Crate program and guesstimated that this patch produces the correct voltages. The two apps were ever so slightly different by 0.01 or so, but I followed the pattern of other ASUS motherboards so this should be correct I hope.