Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvidia Hotspot / VRAM temps #583

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Nvidia Hotspot / VRAM temps #583

merged 4 commits into from
Oct 27, 2021

Conversation

TimSirmovics
Copy link
Contributor

@TimSirmovics TimSirmovics commented Oct 24, 2021 •
edited

Read Nvidia GPU Hot Spot and Memory temps. Adapted from CXWorld/CapFrameX@dcff360

Fixes #440

@TimSirmovics TimSirmovics changed the title Master Nvidia Hotspot / VRAM temps Oct 24, 2021
PhyxionNL
PhyxionNL requested changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@PhyxionNL PhyxionNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice addon.
See comments.

LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs Outdated Show resolved Hide resolved
LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs Outdated Show resolved Hide resolved
LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs Outdated Show resolved Hide resolved
@TimSirmovics
Copy link
Contributor Author

Thanks @PhyxionNL .
I tried to keep the changes as minimal as possible from the source, however your changes do make sense so I will go through and amend it.

PhyxionNL
PhyxionNL requested changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@PhyxionNL PhyxionNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs Outdated Show resolved Hide resolved
@PhyxionNL PhyxionNL merged commit 1701eb9 into LibreHardwareMonitor:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhyxionNL PhyxionNL PhyxionNL requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plan to add VRAM or Hotspot Temps of Graphicscards ? - especially GDDR6X Cards like RTX 3080/3090
2 participants
@TimSirmovics @PhyxionNL