More robust detection of samsung nvme drives #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can confirm this works 🎉 |
nickbabcock
added a commit
to nickbabcock/LibreHardwareMonitor
that referenced
this pull request
Jun 11, 2022
As someone who possesses a 980 Pro, I've been seeing incorrect SMART readings since LibreHardwareMonitor#674 (like power cycle count is always detected as 0). I noticed that LibreHardwareMonitor#388 purposely excludes the 980 Pro from the samsung protocol in favor of the generic one, so I have reverted back to that behavior. I then confirmed that the readings were correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an check when detecting samsung nvme drives (this replicates the check made here: https://github.com/hiyohiyo/CrystalDiskInfo/blob/master/AtaSmart.cpp#L7016
This removes the need for maintaining a list of devices that are not compatible (my PM9A1 drive was not on the list)