Add motherboard: Gigabyte Z690 Gaming X DDR4 (#703) #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHager
commented
Apr 23, 2022
DHager
commented
Apr 23, 2022
DHager
force-pushed
the
motherboard/gigabyte_z690_gaming_x_ddr4
branch
from
aec1fb6
to
67211e9
Compare
PhyxionNL
requested changes
Apr 25, 2022
- Adds support for SYS_FAN4_PUMP control and tachometer
- Adds support for PCH temperature sensor
- There is a DDR5 version of this board out there, I don't know if it differs besides RAM.
DHager
force-pushed
the
motherboard/gigabyte_z690_gaming_x_ddr4
branch
from
67211e9
to
efe1e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to this project for issue #703, it needs checking for newbie-mistakes... I don't actually have C# on my resume. 馃槅
Purpose:
SYS_FAN4_PUMPheader control and tachometerPCHtemperature sensorIn draft form until:
CPU_FANtemp/tach matches boardCPU_OPTtemp/tach matches boardSYS_FAN1temp/tach matches boardSYS_FAN2temp/tach matches boardSYS_FAN3temp/tach matches boardSYS_FAN4_PUMPtemp/tach matches boardOf particular note to reviewers:
MAX_FAN_HEADER_COUNTto support 6 headers, is there a better place to keep the constant?FAN_PWM_CTRL_EXT_REG, I merely picked something 8 higher and am able to controlSYS_FAN4_PUMP.Should I useModel.Z690_GAMING_X_DDR4instead ofModel.Z690_GAMING_X?