Update the minimum framework to net472 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, we can also add a |
PhyxionNL
requested changes
May 1, 2022
|
@PhyxionNL updated as requested! Also just noticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the minimum targeted framework to .NET 4.7.2 in all of the projects in the solution. This PR achieves the intent of the discussion in issue #650. This PR also updates the README to match these updated requirements.
This PR is helpful because Visual Studio 2022 natively includes .NET 4.7.2, but support for 4.6.2 - 4.7.1 requires additional installation.
Additionally, due to the use of C#10 File Scoped Namespaces in the lib project, the solution no longer compiles in VS2019. Because of this, I added a line in the README stating that "Compiling LibreHardwareMonitor requires Visual Studio 2022."
If we would like to change this verbiage, or if someone knows a workaround to retain VS2019 support, please let me know and I'll make those updates to this PR.
Fixes #650