Update EmbeddedController.cs #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of the motherboard model (CROSSHAIR III FORMULA > ROG CROSSHAIR VIII FORMULA). It has the same sensors so I put it with the CROSSHAIR VIII HERO
zeule
reviewed
May 11, 2022
| @@ -158,7 +158,7 @@ public BoardInfo(Model model, BoardFamily family, params ECSensor[] sensors) | |||
| ECSensor.TempChipset, ECSensor.TempCPU, ECSensor.TempMB, | |||
| ECSensor.TempVrm, ECSensor.FanChipset, ECSensor.CurrCPU, ECSensor.VoltageCPU | |||
| ), | |||
| new(new Model[] {Model.ROG_CROSSHAIR_VIII_HERO, Model.ROG_CROSSHAIR_VIII_HERO_WIFI }, BoardFamily.Amd500, | |||
| new(new Model[] {Model.ROG_CROSSHAIR_VIII_HERO, Model.ROG_CROSSHAIR_VIII_HERO_WIFI, Model.ROG_CROSSHAIR_VIII_FORMULA }, BoardFamily.Amd500, | |||
There was a problem hiding this comment.
But Formula, unlike Hero, does not have water sensors, does it?
There was a problem hiding this comment.
If this is the correct model, it seems it does have water headers and connectors:
https://rog.asus.com/motherboards/rog-crosshair/rog-crosshair-viii-formula-model/spec
There was a problem hiding this comment.
Ah, OK. Thanks for checking this for me!
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
May 17, 2022
The ROG CROSSHAIR VIII FORMULA board has the same sensors as the CROSSHAIR VIII HERO [1] thus let's join their definitions which adds missing sensors for Formula. [1] LibreHardwareMonitor/LibreHardwareMonitor#740 Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
zeule
added a commit
to zeule/asus-ec-sensors
that referenced
this pull request
May 17, 2022
The ROG CROSSHAIR VIII FORMULA board has the same sensors as the CROSSHAIR VIII HERO [1] thus let's join their definitions which adds missing sensors for Formula. [1] LibreHardwareMonitor/LibreHardwareMonitor#740 Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
roxell
pushed a commit
to roxell/linux
that referenced
this pull request
May 18, 2022
The ROG CROSSHAIR VIII FORMULA board has the same sensors as the CROSSHAIR VIII HERO [1] thus let's join their definitions which adds missing sensors for Formula. [1] LibreHardwareMonitor/LibreHardwareMonitor#740 Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220517080508.1910953-1-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
intel-lab-lkp
pushed a commit
to intel-lab-lkp/linux
that referenced
this pull request
May 21, 2022
The ROG CROSSHAIR VIII FORMULA board has the same sensors as the CROSSHAIR VIII HERO [1] thus let's join their definitions which adds missing sensors for Formula. [1] LibreHardwareMonitor/LibreHardwareMonitor#740 Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220517080508.1910953-1-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
ColinIanKing
pushed a commit
to ColinIanKing/linux-next
that referenced
this pull request
May 23, 2022
The ROG CROSSHAIR VIII FORMULA board has the same sensors as the CROSSHAIR VIII HERO [1] thus let's join their definitions which adds missing sensors for Formula. [1] LibreHardwareMonitor/LibreHardwareMonitor#740 Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> Link: https://lore.kernel.org/r/20220517080508.1910953-1-eugene.shalygin@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of the motherboard model (CROSSHAIR III FORMULA > ROG CROSSHAIR VIII FORMULA). It has the same sensors so I put it with the CROSSHAIR VIII HERO.