Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROG MAXIMUS Z690 EXTREME GLACIAL #752

Merged
merged 2 commits into from Jun 3, 2022

Conversation

Svek
Copy link
Contributor

@Svek Svek commented Jun 1, 2022

This adds support for the ROG MAXIMUS Z690 EXTREME GLACIAL, as this motherboard comes out of the box with a monoblock the ASUS EC has additional readings/values that are unique for this motherboard, in particular:

  • built-in water flow sensor (inside the monoblock)
  • built-in water temperature (inside the monoblock)
  • optional temperature sensor (header on the motherboard) for water in
  • optional temperature sensor (header on the motherboard) for water out
  • optional water flow sensor (header on the motherboard)

I had to add an additional enum type called TempWaterBlockIn --- which is probably unlikely going to ever be found useful for most motherboards, but there are a few rare ones out there that come with this sensor.

Otherwise, the rest of the code conforms to the rest of the code-base.

@PhyxionNL PhyxionNL merged commit 42182d7 into LibreHardwareMonitor:master Jun 3, 2022
@PhyxionNL
Copy link
Collaborator

Thanks @Svek 🎉

@zeule
Copy link
Contributor

zeule commented Jun 27, 2022

Hey, @Svek! Could you, please, share DSDT for this board (preferably at https://github.com/zeule/asus-ec-sensors) to add it to the Linux HWMON driver?

@Svek
Copy link
Contributor Author

Svek commented Jun 27, 2022

@zeule I followed the readme on your site as noted, back when I started working on this.

Method (BREC, 1, Serialized)
{
   Return (Ones)
   Return (Ones)
}

This didn't look promising, so I didn't continue further. Is there something else I can do?

@zeule
Copy link
Contributor

zeule commented Jun 27, 2022

Yes, please share the DSDT content so I can find what ACPI mutex is used (if any) by the firmware to guard access to EC and SIO.

@zeule
Copy link
Contributor

zeule commented Jun 27, 2022

… so I can find what ACPI mutex is used (if any) by the firmware to guard access to EC and SIO.

And keep it for possible future refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants