Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Noise Sensors support #814

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Add Noise Sensors support #814

merged 6 commits into from
Sep 16, 2022

Conversation

severgun
Copy link
Contributor

Added sensors type: Noise
Added icon

@severgun severgun mentioned this pull request Sep 11, 2022
Merged
6 tasks
@PhyxionNL
Copy link
Collaborator

PhyxionNL commented Sep 14, 2022 •
edited

Thanks! Please remove the GridV3 from this PR.
What is the source for the icon? It should have a permissable license.

@severgun
Copy link
Contributor Author

Replaced icon https://www.iconfinder.com/icons/35383/settings_sound_speaker_icon

@PhyxionNL
Copy link
Collaborator

Replaced icon https://www.iconfinder.com/icons/35383/settings_sound_speaker_icon

It's very hard to see, is there another? Or maybe with a little less padding? 😊

@severgun
Copy link
Contributor Author

16x16 hard to see by default.
What about this? https://commons.wikimedia.org/wiki/File:Sound-icon.svg

@PhyxionNL
Copy link
Collaborator

I agree, but most icons are still somewhat visible 🙂 Yeah, that icon looks good.

@severgun
Copy link
Contributor Author

LibreHardwareMonitor_elG45PBpY2

@PhyxionNL PhyxionNL merged commit 34c9284 into LibreHardwareMonitor:master Sep 16, 2022
@PhyxionNL
Copy link
Collaborator

Thanks @severgun, looks good now, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@severgun @PhyxionNL