Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows storage spaces #871

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

marcadamsge
Copy link
Contributor

I had the same problem as this issue #396, I use a windows storage space on two nvmes and I would like to monitor the temperature of the nvmes. There's window's storage management api that can be used to explore the Disks and PhysicalDisks. With this PR I can now see my two nvmes:

Screenshot 2022-11-06 161141

The Msft Storage Space is a storage space on top of the two Kingston SFYRS1000G

Copy link
Contributor Author

@marcadamsge marcadamsge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed review @PhyxionNL 👍

LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs Outdated Show resolved Hide resolved
LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs Outdated Show resolved Hide resolved
LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@PhyxionNL PhyxionNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Few small nits left, rest looks good!

LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs Outdated Show resolved Hide resolved
LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs Outdated Show resolved Hide resolved
@PhyxionNL PhyxionNL merged commit f2b93c0 into LibreHardwareMonitor:master Nov 10, 2022
@PhyxionNL
Copy link
Collaborator

Thanks a lot @marcadamsge in getting this added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants