Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Central Package Management for NuGet 6.2+ #879

Merged

Conversation

pomianowski
Copy link
Contributor

PR adds support for the newer package management system.
Microsoft Learn | Central Package Management (CPM)

@PhyxionNL
Copy link
Collaborator

I think it makes more sense to only centralize the common used packages? OxyPlot for example isn't used by the library.

nuget.config Outdated Show resolved Hide resolved
@pomianowski
Copy link
Contributor Author

I think it makes more sense to only centralize the common used packages? OxyPlot for example isn't used by the library.

For the new CPM type, it is not recommended to put version definitions inside the projects. I believe that this is a good method to have "one source of truth" about what dependencies we use. This facilitates not only updates, but also dependabot and, in general, verification of what our project is using.

@PhyxionNL PhyxionNL merged commit f1ea904 into LibreHardwareMonitor:master Nov 18, 2022
@PhyxionNL
Copy link
Collaborator

Thanks, merged @pomianowski!

PhyxionNL added a commit that referenced this pull request Nov 18, 2022
@PhyxionNL
Copy link
Collaborator

PhyxionNL commented Nov 18, 2022

Seems to break CI, let's wait a bit until VS is updated for #878.

PhyxionNL added a commit that referenced this pull request Nov 27, 2022
#902)

Revert "Revert "Revert "Use Central Package Management for NuGet 6.2+ (#879)"" (#902)"

This reverts commit 0d37e98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants