Add view menu item to clear the plot #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a view menu item to clear the plotted value data (satisfies LibreHardwareMonitor#859)
PhyxionNL
reviewed
Nov 20, 2022
| /// <summary> | ||
| /// Resets the plot graph. | ||
| /// </summary> | ||
| void ResetPlot(); |
There was a problem hiding this comment.
ResetPlot > ClearValues. Also update comment.
There was a problem hiding this comment.
Not entirely sure I understand what you're asking. Do you want the function to be called ClearValues instead of ResetPlot? And update the comment to what?
Is this what you're asking for
/// <summary>
/// Clears the values stored in <see cref="Sensor._values"/>.
/// </summary>
void ClearValues();
There was a problem hiding this comment.
Yes, that's right! The comment should refer to
though.Rename function to ClearValues() and update comment in ISensor.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a view menu -> "Reset Plot" item to clear the plotted value data.
I've had this feature in my own custom build for a while now, and I added it as a separate entry rather than just "Reset min/max/plot" on one button because there have been times where I only want to reset the min / max values but keep the plot, and likewise reset the plot but keep the maximum / minimum values intact.
(satisfies #859)