Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Hard Disk Drives" menu option to read "Storage Devices" #947

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Change "Hard Disk Drives" menu option to read "Storage Devices" #947

merged 3 commits into from
Jan 14, 2023

Conversation

generic-user1
Copy link
Contributor

@generic-user1 generic-user1 commented Jan 4, 2023

Change the text of the "File > Hardware > Hard Disk Drives" menu option to read "Storage Drives" (so that it is now "File > Hardware > Storage Drives").

The motivation for this change is that the option affects Solid State Drives in addition to Hard Disk Drives.

Change the text of the "File > Hardware > Hard Disk Drives" menu option to read "Internal Storage Drives".
Motivation is that this option affects Solid State Drives in addition to Hard Disk Drives.
@killo3967
Copy link

And ¿ what about the external usb/esata ? I have now all disk insternal and external monitorized, and the menu option caption is correct for me.

@ntoff
Copy link
Contributor

ntoff commented Jan 9, 2023

It also reads certain aspects of my iSCSI network drive. Why not just "Storage Devices" to make it universal?

@generic-user1 generic-user1 changed the title Change "Hard Disk Drives" menu option to read "Internal Storage Drives" Change "Hard Disk Drives" menu option to read "Storage Drives" Jan 9, 2023
@generic-user1
Copy link
Contributor Author

Updated to "Storage Drives"

@JoeBroesele
Copy link
Contributor

Honestly, the term "Storage Devices" seems more generic and future-proof to me. I would opt for that. Google also seems to suggest that. ;)

grafik

@generic-user1 generic-user1 changed the title Change "Hard Disk Drives" menu option to read "Storage Drives" Change "Hard Disk Drives" menu option to read "Storage Devices" Jan 10, 2023
@generic-user1
Copy link
Contributor Author

Misread "Devices" as "Drives" initially. Changed to "Storage Devices"

@killo3967
Copy link

Storage Devices It's ok for me.

@PhyxionNL PhyxionNL merged commit 038952a into LibreHardwareMonitor:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants