Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ASRock Z790 Taichi/Z790 Taichi Carrara. #962

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

papa12804
Copy link
Contributor

Add support for fans and temps, but voltage readings in NCT6686D chip#1 is range from 0x106 to 0x114.
The _voltageRegisters in Nct677X is range from 0x120 to 0x13C, there needs some revise.

@PhyxionNL
Copy link
Collaborator

Do you still want to work on this PR @papa12804?

@papa12804
Copy link
Contributor Author

I can't come up with some good ideas for this now, adding brand judgments to Nct677X will make it messy.

@PhyxionNL
Copy link
Collaborator

Hmm, NCT6686D (and NCT6683D) should use the same voltage registers as NCT6687D. I'll leave some feedback though :)

@papa12804
Copy link
Contributor Author

Hmm, NCT6686D (and NCT6683D) should use the same voltage registers as NCT6687D. I'll leave some feedback though :)

I think each brand has its own NCT6686D or NCT6683D or NCT6687D firmware, so the location of the fan, temperature and voltage registers may vary.

@PhyxionNL PhyxionNL merged commit af0f4b6 into LibreHardwareMonitor:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants