Fix ASUS X470-I uncontrollable fans due to the wrong fan offset (fixes #802) #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had correct fan readings for the fan on the MB, but could not control them. Found in the code there is an offset of 2; the comment states that the first 2 fans always show zero. I removed the offset - now I have 5 fan controls (which is not correct, since the MB only has 3 fan headers), but the first 2 actually control the fans. I assume that the offset is either outdated and no longer needed, or it should offset 2 fans from the end of the array, not the start of it. I don't have all the headers populated, so cannot fully test whether the offset from the end is fine. I built the LHM library and added it to both LHM and FanCtrl v1.5.6, in both cases I could control the fans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had correct fan readings for the fan on the MB, but could not control it. Found in the code there is an offset of 2; the comment states that the first 2 fans always show zero. I removed the offset - now I have 5 fan controls (which is not correct, since the MB only has 3 fan headers), but the first one actually control the fans. I assume that the offset is either outdated and no longer needed, or it should offset 2 fans from the end of the array, not the start of it. I don't have all the headers populated, so cannot fully test whether the offset from the end is fine.
I built the LHM library and added it to both LHM and FanCtrl v1.5.6, in both cases I could control the fans.
Should also close #802, since it describes the same issue.