GSoC 2018 Project: PDF generator code for Patient Report section #1165

2208Abhinav · 2018-06-04T05:50:23Z

This code will create the PDFs for the Patient Report section which will be tested using Test Download button.

2208Abhinav · 2018-06-06T11:48:47Z

An error for Demographics option. Working on it.

aethelwulffe · 2018-06-06T13:52:33Z

Need any help?
-You can always post errors here.

aethelwulffe · 2018-06-06T13:54:34Z

Sorry, I have not tested this yet myself. I have been working on the PR's from bottom up.

aethelwulffe · 2018-06-06T19:41:55Z

Is this ready to test?

2208Abhinav · 2018-06-07T02:02:39Z

yes @aethelwulffe its ready to test, just Demographics option is having some problems.

modules/pdf_generator/report/procedures.php

aethelwulffe · 2018-06-11T14:56:10Z

What are the dems issues? Not finding them. Was this procedures report inclusion the fix?

muarachmann · 2018-06-11T14:57:24Z

@2208Abhinav just looked at your code cool. Went through the code and saw the dowload button didnt have a class of cp-output just make sure you dont forget to add that we are going to do a revamping of those stuffs after gsoc

aethelwulffe · 2018-06-11T15:02:19Z

Mua, if you do a "looking at cool code" then WRITE A REVIEW. K? We need you here, you are valuable, but we also have you on the hook for this GSOC thing, and we defined community involvement as "writing reviews" among other things. 😛

-This here is supposed to be a lateral organization. Everybody should be worked up to the point where they are part of the integration process. Right now, the dumbest three old turds in the project are the integrators and handle all the reviews. That is silly. 😉

2208Abhinav · 2018-06-11T15:40:22Z

@aethelwulffe the error correction is not included yet in the code. Is the Procedures Order code working fine?

2208Abhinav · 2018-06-11T15:44:25Z

I think for the error that there are some HTML tags not closed properly that is why data is leaking. I will solve it.

aethelwulffe · 2018-06-11T17:02:17Z

Oh...We have always had HTML errors in this junk. I tend to overlook such things, as none of this has ever worked right. I have always had...low expectations with this part of the application. I will adjust the bar up a notch or two!

modules/pdf_generator/report/billing.php

tmccormi · 2018-06-15T01:22:27Z

modules/pdf_generator/report/insurance.php

+    global $content_insu;
+    if (@array_key_exists($key,$retar)) {
+        $length = sizeof($retar{$key});
+        if ($retar{$key}[$length]{"value"} != "0000-00-00 00:00:00") {


Be careful with Date/Time strings in INNODB default MYSQL that format is a bad date, an empty date will be NULL not zero filled. LibreEHR has some old code (and data) that may already have ZERO dates, so all tests need to support both formats for now.

@tmccormi So am I required to use condition like if(($retar{$key}[$length]{"value"} != "0000-00-00 00:00:00")&&($retar{$key}[$length]{"value"} != NULL))?

tmccormi · 2018-06-15T01:23:38Z

modules/pdf_generator/report/procedures.php

+    "WHERE po.procedure_order_id = ?",
+    $orderid);
+
+    $content_pro .= "(" . oeFormatShortDate(substr($orow['date'], 0, 10)) . ")<br><table border=\"1\" style=\"background-color: silver\"><tr><td>Patient ID</td>".


ALL Strings need to be wrapped in xlt() translation functions...

...and they should be checked for standard terms. If something exists in the translations tables, you should use that (or change it everywhere). Not a bad idea when those who can provide translations actually go and do so. We have not ...ever... checked or updated the xlt() tables.

@tmccormi should I use xlt() only with strings like xlt("Procedures Order") or also with the variables like xlt($facility['name']) ?

Only for labels/instructions that are hard-coded. Never for variables. The translation is for the application, not any of the contents. The translations come from an old-school table lookup, so any new text added to applications must also be added to the translations table.

tmccormi · 2018-06-15T01:25:23Z

modules/pdf_generator/selector.php

+
+$pdf = new EHRPDF('p', 'mm', array(216, 279), true, 'UTF-8', false);//potrait, pdf unit in mm and height=279mm, width=216mm
+$pdf->AddPage();
+$pdf->SetFont('dejavusans', '', 19);


Seems odd to set the font over and over, perhaps this should be a higher level setting or at least a defined variable at the top?

Might be needed with every call, BUUUT, I think that dejavusans is the asset's default font anyway....which is not saying that you don't have to specify...I don't know.

muarachmann · 2018-06-19T16:25:12Z

@2208Abhinav please edit your PR title with a GSOC 2018 prefix or suffix had a hard time finding this

aethelwulffe · 2018-06-19T16:30:52Z

@muarachmann You can filter issues/PR's by choosing the tag "GSOC 2018"

2208Abhinav · 2018-06-20T05:34:05Z

I think @aethelwulffe is right but still I changed the title @muarachmann 😄

…rs added and new code for history

2208Abhinav · 2018-07-07T13:13:07Z

@aethelwulffe test the code its ready 🤓 but just leave the demographics for now, it will be corrected in next submission.

2208Abhinav · 2018-07-07T13:49:21Z

@tmccormi due to merge conflict I removed the second download button, but still you can test by using previous single download button.

muarachmann · 2018-07-07T14:53:23Z

modules/pdf_generator/report/procedures.php

-    if($orow['specimen_type'])  $content_pro .= "<td>Specimen Type</td>";
-                    
+    if($orow['specimen_type'])  $content_pro .= "<td>" . xlt("Specimen Type") . "</td>";
+
    $content_pro .= "<td>" . $orow['specimen_type'] . "</td></tr></table><br><br>";


Good that you included the xlt functions but these green lines and red stuffs makes my eyes go 🙄 will test and get back to a line id needed

muarachmann · 2018-07-07T14:55:43Z

Good you included the xlt functions those green and red lines make my eyes 👀 will test and get back to the line in case.

muarachmann · 2018-07-07T14:56:35Z

Worry not much about merge conflict for your GSoC project at the end it would be resolved

2208Abhinav · 2018-07-08T04:21:10Z

@teryhill did you check the code? I want the output PDF of the options selected collectively that I mentioned on the chat.

aethelwulffe · 2018-07-12T17:24:30Z

Checks worked fine, but need to address the zero-date concern from Tony.

2208Abhinav · 2018-07-13T08:11:14Z

@aethelwulffe I will do it in the end first I am making the whole base then minor issues will be solved.
When I will complete the report section I will do that.

aethelwulffe · 2018-07-14T14:13:02Z

@2208Abhinav OH, I know all that. Just documenting the status of a test...for the at-the-moment. I have been really doing poorly keeping up with testing of branches for the last two weeks, and I am just trying to get on top of things.
For the day-to-day operations of a clinic, retro wrong-headed ideas like exporting things to a PDF document instead of using a data exchange API are actually vital to how they do business in the here and now. The stuff you are working on here directly affects the average user's performance and basic quality of life (less frustration) in a major daily way. I should be keeping up with testing to help out and verify.

2208Abhinav · 2018-07-21T06:01:53Z

@tmccormi @teryhill @aethelwulffe I pushed some new code, removed error for Demographics please test the code.

aethelwulffe · 2018-07-23T15:51:01Z

Testing will commence at 15:00 EST

aethelwulffe · 2018-07-31T17:17:53Z

Hi folks,
Torn shoulder keeping me off the computer a lot right now.
-Testing the Who is Online branch piled on my error log to the point everything shut down. This branch does it too.
About 100,000 error sets per second are generated repeating this:

[Tue Jul 31 13:09:57.485137 2018] [:error] [pid 1068:tid 1956] [client ::1:50491] PHP Notice:  Undefined offset: 1 in C:\\xampp\\htdocs\\branchtest\\library\\appointments.inc.php on line 174, referer: http://localhost/branchtest/modules/calendar/index.php?&framewidth=953
[Tue Jul 31 13:09:57.485137 2018] [:error] [pid 1068:tid 1956] [client ::1:50491] PHP Notice:  Undefined offset: 2 in C:\\xampp\\htdocs\\branchtest\\library\\appointments.inc.php on line 174, referer: http://localhost/branchtest/modules/calendar/index.php?&framewidth=953
[Tue Jul 31 13:09:57.485137 2018] [:error] [pid 1068:tid 1956] [client ::1:50491] PHP Notice:  Only variable references should be returned by reference in C:\\xampp\\htdocs\\branchtest\\library\\encounter_events.inc.php on line 403, referer: http://localhost/branchtest/modules/calendar/index.php?&framewidth=953

Sure, those are warnings, but why is it getting called so much? Basically this seems to be killing my system. I dare not push the current branch to production.

aethelwulffe · 2018-07-31T17:32:39Z

The errors I am getting are not related to this.
The demographics section looks great....BUUUT it should not (meaning our dems default content) have the social security number....
-Nothing to do with this though.

aethelwulffe

PDF prototype in there, but this commit tests well.
When you need another test (or you declare victory) I am ready to do so.

2208Abhinav · 2018-08-10T16:51:59Z

@teryhill @aethelwulffe @tmccormi @nileshprasad137 I did the final commit please check it. I will integrate the PDF generation code for @Trodrige project after GSOC. I have writen the code for it and I am waiting for its integration in main EHR software.

2208Abhinav · 2018-08-10T17:30:54Z

PDF code for Review of Systems and Review of Systems Checks is left due due to previous bugs.

2208Abhinav · 2018-08-12T13:55:26Z

NOTE : The code is left for Review of Systems and Review of Systems Checks.
And integration with @Trodrige project is left.

aethelwulffe · 2018-08-27T16:15:01Z

Tested as-is

aethelwulffe · 2018-08-27T16:17:19Z

Review of Systems and Review of Systems Checks is due for replacement itself. Long overdue. There are contrib repo chunks related to a possible replacement.

aethelwulffe · 2019-01-18T19:41:23Z

@2208Abhinav Could you please address @tmccormi request to change the comment headers so we can merge this? It is an awesome and much needed thing. Pretty please?

2208Abhinav · 2019-01-19T09:37:18Z

@aethelwulffe I added the new comment headers like it was asked long ago.

2208Abhinav · 2019-01-22T08:54:02Z

@aethelwulffe what other changes do I need to add for this to be mergeable

aethelwulffe · 2019-01-22T14:10:57Z

I was looking at an old commit.
Yes, this can be merged.
I will do the testing of the PDF's immediately. If someone wants to review this again, they may do so, but I thing 4-5 months of just sitting here is plenty long enough, and unless they post protests, I am going to merge this pending on my test results.

aethelwulffe · 2019-01-22T14:24:12Z

OK.
Pulled down a pretty extensive PDF which you can find to look at at https://suncoastconnection.com/downloads/screenies/test_rat.pdf.
If anything, there is only some possible translation or date transformation issues in the code, and even those might not have any real reason to be addressed in this commit.
Merging this and moving on before the NEXT YEAR GSOC starts!
This fixes a major problem for the EHR.

PDF generator code for Patient Report section

61d6e59

aethelwulffe added Re-Factoring Feature: Reports Feature: Patient Demographics GSoC2018 FEATURE: Printing/Export labels Jun 6, 2018

Procedure orders PDF generation code

f39bad4

aethelwulffe reviewed Jun 11, 2018

View reviewed changes

modules/pdf_generator/report/procedures.php Show resolved Hide resolved

tmccormi requested changes Jun 15, 2018

View reviewed changes

2208Abhinav changed the title ~~PDF generator code for Patient Report section~~ GSoC 2018 Project: PDF generator code for Patient Report section Jun 20, 2018

PDF generation code for clinical instructions, issues, procedure orde…

f70ee87

…rs added and new code for history

Merge branch 'master' into pdf_generator

d6ee617

muarachmann reviewed Jul 7, 2018

View reviewed changes

Added support for other sections and removed Demographics error

1c0156e

aethelwulffe reviewed Jul 31, 2018

View reviewed changes

Improved date comparison, removed bugs and added other features

9fc65b7

aethelwulffe approved these changes Aug 27, 2018

View reviewed changes

robbyoconnor force-pushed the master branch from d74d7ba to 80d9e4c Compare October 31, 2018 04:40

aethelwulffe merged commit 3f8b1d3 into LibreHealthIO:master Jan 22, 2019

GSoC 2018 Project: PDF generator code for Patient Report section #1165

GSoC 2018 Project: PDF generator code for Patient Report section #1165

Conversation

2208Abhinav commented Jun 4, 2018

2208Abhinav commented Jun 6, 2018 • edited Loading

aethelwulffe commented Jun 6, 2018

aethelwulffe commented Jun 6, 2018

aethelwulffe commented Jun 6, 2018

2208Abhinav commented Jun 7, 2018

aethelwulffe commented Jun 11, 2018

muarachmann commented Jun 11, 2018 • edited Loading

aethelwulffe commented Jun 11, 2018 • edited Loading

2208Abhinav commented Jun 11, 2018

2208Abhinav commented Jun 11, 2018

aethelwulffe commented Jun 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

muarachmann commented Jun 19, 2018 • edited Loading

aethelwulffe commented Jun 19, 2018

2208Abhinav commented Jun 20, 2018

2208Abhinav commented Jul 7, 2018

2208Abhinav commented Jul 7, 2018

Choose a reason for hiding this comment

muarachmann commented Jul 7, 2018

muarachmann commented Jul 7, 2018 • edited Loading

2208Abhinav commented Jul 8, 2018

aethelwulffe commented Jul 12, 2018

2208Abhinav commented Jul 13, 2018

aethelwulffe commented Jul 14, 2018

2208Abhinav commented Jul 21, 2018 • edited Loading

aethelwulffe commented Jul 23, 2018

aethelwulffe commented Jul 31, 2018

aethelwulffe commented Jul 31, 2018

aethelwulffe left a comment

Choose a reason for hiding this comment

2208Abhinav commented Aug 10, 2018

2208Abhinav commented Aug 10, 2018

2208Abhinav commented Aug 12, 2018

aethelwulffe commented Aug 27, 2018

aethelwulffe commented Aug 27, 2018

aethelwulffe commented Jan 18, 2019

2208Abhinav commented Jan 19, 2019

2208Abhinav commented Jan 22, 2019

aethelwulffe commented Jan 22, 2019

aethelwulffe commented Jan 22, 2019

2208Abhinav commented Jun 6, 2018 •

edited

Loading

muarachmann commented Jun 11, 2018 •

edited

Loading

aethelwulffe commented Jun 11, 2018 •

edited

Loading

muarachmann commented Jun 19, 2018 •

edited

Loading

muarachmann commented Jul 7, 2018 •

edited

Loading

2208Abhinav commented Jul 21, 2018 •

edited

Loading