Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of patient finder with tags on large DB #1232

Merged
merged 1 commit into from Sep 5, 2018

Conversation

kchapple
Copy link
Contributor

On a large DB, the join on the tf_patient_tags pivot table caused big performance penalty, so I added a migration to insert an index to pid col of tf_patient_tags pivot table.

--
-- Indexes for table `tf_patients_tags`
--

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really the only code. Migrations are only run once. There is no need for conditional logic in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the migration require any user input to run?

@kchapple
Copy link
Contributor Author

kchapple commented Aug 28, 2018 via email

@tmccormi tmccormi merged commit 23f511c into master Sep 5, 2018
@tmccormi tmccormi deleted the tag_performance branch September 5, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants