UI improvements in Encounter Screens #641
Conversation
|
@nileshprasad137 @pri2si17-1997 @azwreith the three of y'all are proving to be tremendous assets to this project and I for one am very thankful to work with each of you. I know that each of you are giving 110%. |
|
Thanks and I'll continue to do so!! |
| <!--<script type="text/javascript" src="<?php //echo $GLOBALS['webroot']; ?>/library/textformat.js"></script>--> | ||
| <!--<script type="text/javascript" src="<?php //echo $GLOBALS['webroot']; ?>/library/js/jquery.datetimepicker.full.min.js"></script>--> | ||
| <!--link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/fancybox/3.0.47/jquery.fancybox.min.css" />--> | ||
| <!--<script src="https://cdnjs.cloudflare.com/ajax/libs/fancybox/3.0.47/jquery.fancybox.min.js"></script>--> |
There was a problem hiding this comment.
remove the commented out code if it is not needed
There was a problem hiding this comment.
Sure. I just forgot to remove this.
| jQuery.browser.version = RegExp.$1; | ||
| } | ||
| })(); | ||
| </script> |
There was a problem hiding this comment.
Is this going to be used else where? Could it go in a common function that was called when needed?
There was a problem hiding this comment.
It will not be needed everywhere but certainly at many places. Yeah, seems like a good idea. I would keep this in a different function in the headers file.
| <?php html_header_show(); | ||
| // Include Bootstrap Library | ||
| call_required_libraries(true,false,false,false); | ||
| ?> | ||
| <link rel="stylesheet" type="text/css" href="<?php echo $GLOBALS['standard_js_path']?>fancybox-1.3.4/jquery.fancybox-1.3.4.css" media="screen" /> | ||
| <style type="text/css">@import url(../../../library/dynarch_calendar.css);</style> |
There was a problem hiding this comment.
this should not be needed with the new date picker. I must have missed removing it.
| <link rel="stylesheet" type="text/css" href="<?php echo $GLOBALS['standard_js_path']?>fancybox-1.3.4/jquery.fancybox-1.3.4.css" media="screen" /> | ||
| <style type="text/css">@import url(../../../library/dynarch_calendar.css);</style> | ||
|
|
||
| <!-- supporting javascript code --> | ||
| <script type="text/javascript" src="<?php echo $GLOBALS['webroot'] ?>/library/js/jquery-1.7.2.min.js"></script> | ||
| <script type="text/javascript" src="<?php echo $GLOBALS['webroot'] ?>/library/dialog.js"></script> | ||
| <script type="text/javascript" src="../../../library/textformat.js"></script> | ||
| <script type="text/javascript" src="../../../library/dynarch_calendar.js"></script> |
There was a problem hiding this comment.
Should not be needed with the new datepicker.
|
Made the changes . |
|
We need to check if this resolves #640 . |
|
Hi @nileshprasad137 have you worked on |
|
|
|
We have plans...somewhere...for replacing openflashchart...not that it is a bad tool really. |
I tried hard to keep the frames as responsive as possible.
This PR attempts to improve UI over following screens::