-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#393 issue: Update Comments #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, very good translations! Please fix the issues mentioned, then this can be merged.
core/.classpath
Outdated
@@ -51,16 +51,5 @@ | |||
<attribute name="test" value="true"/> | |||
</attributes> | |||
</classpathentry> | |||
<classpathentry kind="src" path=".apt_generated"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no unrelated changes.
@@ -1,13 +1,13 @@ | |||
eclipse.preferences.version=1 | |||
org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled | |||
org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore | |||
org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull | |||
org.eclipse.jdt.core.compiler.annotation.nonnull=javax.annotation.Nonnull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no unrelated changes.
@@ -38,19 +38,19 @@ | |||
private static GlobalFunctions instance; | |||
|
|||
/** | |||
* Enthält die im Funktionen-Abschnitt der wollmux,conf definierten Funktionen. | |||
* Contains the functions defined in the functions section of wollmux.conf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this file was already translated in #429
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I revert the changes back to as it was(will contain German comments then)?
@@ -28,19 +28,19 @@ | |||
import org.libreoffice.ext.unohelper.common.UNO; | |||
|
|||
/** | |||
* Hilfsklasse, die es ermöglicht, UNO-Componenten in HashMaps abzulegen; der |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this file was already translated in #429
core/src/main/java/de/muenchen/allg/itd51/wollmux/Shortcuts.java
Outdated
Show resolved
Hide resolved
* | ||
* @param node | ||
* z.B. "/org.openoffice.Inet/Settings" | ||
* e.g. "/org.openoffice.inet/settings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't change this, this is defined in LibreOffice.
@@ -78,26 +78,26 @@ public static String verfuegbarenPfadVerwenden(String fileName) | |||
} | |||
|
|||
/** | |||
* Arbeitet wie | |||
* {@link Dateinamensanpassungen#verfuegbarenPfadVerwenden(String)} und |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reference to a method, don't translate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't change as the file was locked(read-only mode).
idl/.classpath
Outdated
@@ -23,11 +23,6 @@ | |||
<attribute name="maven.pomderived" value="true"/> | |||
</attributes> | |||
</classpathentry> | |||
<classpathentry excluding="**" kind="src" output="target/classes" path="target/generated-sources/idl"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't change as the file was locked(read-only mode).
oxt/.classpath
Outdated
@@ -46,16 +46,5 @@ | |||
<attribute name="test" value="true"/> | |||
</attributes> | |||
</classpathentry> | |||
<classpathentry kind="src" path=".apt_generated"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no unrelated changes.
@@ -1,8 +1,15 @@ | |||
eclipse.preferences.version=1 | |||
org.eclipse.jdt.core.compiler.annotation.nonnull=javax.annotation.Nonnull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't change a few files as they were locked(read-only)
I am not able to figure out why the checks are failing. It'd be great if you can help me out. |
Check this: https://ci.libreoffice.org/job/WollMux/view/change-requests/job/PR-431/lastBuild/console |
Oh sorry I just noticed that link is not accessible without Jenkins login. Here's the relevant part:
|
Changed the German comments to English comments of the files
core/src/main/java/de/muenchen/allg/itd51/wollmux/GlobalFunctions.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/HashableComponent.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/OpenExt.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/Shortcuts.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/SyncActionListener.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/TextModule.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/WollMuxFehlerException.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/WollMuxFiles.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/WollMuxSingleton.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/AlwaysTrueFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/BindFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/Dateinamensanpassungen.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/DivideFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/ExternalFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/ExternalFunctionFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/Function.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/FunctionFactory.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/FunctionLibrary.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/MultiFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/NumberCompareFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/NumberFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/SignFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/Value.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/ValueFunction.java
core/src/main/java/de/muenchen/allg/itd51/wollmux/func/Values.java