Skip to content

Commit

Permalink
Planted FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
Katarina Behrens authored and Katarina Behrens committed Feb 23, 2016
1 parent 13f09f4 commit 0f71008
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/ag/ion/bion/officelayer/util/InstallationFinder.java
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
* the user's home directory. Note, that the .sversionrc file will be omitted
* for OOo 2.0</p>
*/
//FIXME: split this class into InstallationFinderUnix and InstallationFinderWindows
final class InstallationFinder {

private static final String SYSPROP_NAME =
Expand Down Expand Up @@ -124,6 +125,8 @@ public static String getPath() {
if ( osname.startsWith( "Windows" ) ) {
// get the installation path from the Windows Registry
// (Windows platform only)
// FIXME: this doesn't work currently as it needs unowinreg.dll
// (part of Libreoffice SDK) which we don't have
path = getPathFromWindowsRegistry();
} else {
// get the installation path from the PATH environment
Expand Down
2 changes: 2 additions & 0 deletions src/ag/ion/bion/officelayer/util/OfficeLoader.java
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ private static void callUnoinfo(String path, ArrayList<URL> urls) {
" unoinfo: " + e);
return;
}
//FIXME: perhaps remove this one & the whole Drain class entirely
//we're not doing anything w/ content of stderr anyway
new Drain(p.getErrorStream()).start();
int code;
byte[] buf = new byte[1000];
Expand Down
1 change: 1 addition & 0 deletions src/ag/ion/bion/officelayer/util/WinRegKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ private static native boolean winreg_RegQueryInfoKey(
long[] maxValueLen, long[] secDescriptor );

// load the native library unowinreg.dll
// FIXME: drop dependency on unowinreg.dll and use com.ice.jni.registry instead
static {
try {
ClassLoader cl = WinRegKey.class.getClassLoader();
Expand Down

0 comments on commit 0f71008

Please sign in to comment.