Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arduino Nano V3 package/device #10

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

oblerion
Copy link

@oblerion oblerion commented Jun 28, 2022

Added package and device for arduino nano v3

Package:
Capture d’écran du 2022-06-28 16-41-51

Device:
Capture d’écran du 2022-06-28 16-42-48

SUMMARY
DATASHEETS / REFERENCES

board mesure https://jpralves.net/post/2016/11/15/arduino.html

OPEN QUESTIONS / UNRESOLVED ISSUES
CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@oblerion oblerion changed the title Added Arduino Nano V3 Added Arduino Nano V3 package/device Jun 28, 2022
@ubruhin
Copy link
Contributor

ubruhin commented Jul 30, 2022

Thanks for the contribution! I have some comments regarding the package:

  • The diameter of the four holes seems to be too small
  • The outline violates several rules of the placement layer and documentation layer conventions. Please read these conventions again and apply all these rules. The orientation should also be clarified with the placement layer drawing - in this case, I think I'd simply draw the placement outline including USB connector, then the orientation is clear.
  • Might also be good to make the first pad rectangular instead of round, then the orientation would even be clear without silkscreen.
  • I'd remove the text in the center. The {{VALUE}} text at the bottom will contain the text "Arduino Nano V3" anyway by default so this text would then be duplicated.
  • I'm not sure about adding all the pad texts - so far we never did that. At least they are only on the documentation layer, so not on silkscreen. @dbrgn do you have an opinion about that? Maybe simply moving them to inside the package to avoid conflicts with possible other components around the Arduino? Or better remove them completely?

@oblerion
Copy link
Author

Capture d’écran du 2022-07-31 11-03-27

  • The diameter of the four holes seems to be too small
  • The outline violates several rules
  • The orientation should also be clarified with the placement layer drawing - in this case, I think I'd simply draw the placement outline including USB connector, then the orientation is clear.
  • Might also be good to make the first pad rectangular instead of round, then the orientation would even be clear without silkscreen.
  • I'd remove the text in the center. The {{VALUE}} text at the bottom will contain the text "Arduino Nano V3" anyway by default so this text would then be duplicated.
  • I'm not sure about adding all the pad texts - so far we never did that. At least they are only on the documentation layer, so not on silkscreen. @dbrgn do you have an opinion about that? Maybe simply moving them to inside the package to avoid conflicts with possible other components around the Arduino? Or better remove them completely?

@ubruhin
Copy link
Contributor

ubruhin commented Jul 31, 2022

Thanks for the update! Just one thing is now worse than before 🙈 The polygons are now on the "Board Outline" layer, which would lead to a huge cutout milled into your board and is thus fatal 😉

I wonder where the library conventions are not clear about the outline polygons... There should be two outline polygons:

  • One on the "Top Placement" layer which will then be used as silkscreen and thus should be helpful for assembly of that device. Typically it's a line around (fully outside, e.g. not drawing the whole USB connector) the package. For Arduino Uno, it would be just a single, closed line around the whole Arduino.
  • One on the "Top Documentation", containing the whole outline and additional details (e.g. the whole USB connector) about the package. It does not appear on the silkscreen but usually it will be exported in an assembly drawing as an additional placement help.

Examples (the lighter polygons are "Top Placement", the darker polygons are "Top Documentation"):

image

image

I hope this helps. As a simplification, I'd also be fine with only a "Top Placement" polygon if that helps - but "Board Outline" is clearly the wrong layer and needs to be changed :)

@oblerion
Copy link
Author

oblerion commented Aug 1, 2022

You ask about outline so i change to outline XD
I have only understand this not a board, but an part of board.

@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Aug 25, 2023
@ubruhin ubruhin self-assigned this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants