Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMA connector package: 142-0701-801 #1

Merged
merged 2 commits into from Sep 10, 2019
Merged

SMA connector package: 142-0701-801 #1

merged 2 commits into from Sep 10, 2019

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Jul 13, 2019

@dbrgn dbrgn requested review from rnestler and ubruhin July 13, 2019 22:50
@dbrgn dbrgn added addition New library element. ready for review Waiting for review by maintainers. labels Jul 13, 2019
@dbrgn dbrgn mentioned this pull request Aug 6, 2019
Closed
@ubruhin
Copy link
Contributor

ubruhin commented Sep 9, 2019

I would place the {{NAME}} label on the right side too, above the {{VALUE}} label. This makes the package much more compact. Otherwise it looks good 👍

@ubruhin ubruhin mentioned this pull request Sep 9, 2019
Merged
@dbrgn
Copy link
Collaborator Author

dbrgn commented Sep 10, 2019

Fixed!

2019-09-10-094824_532x398_scrot

I also renamed the package to 142-0701-80X to include both plating variants.

@dbrgn dbrgn merged commit 50a2d3d into master Sep 10, 2019
@dbrgn dbrgn deleted the sma-connector branch September 10, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnestler rnestler Awaiting requested review from rnestler

@ubruhin ubruhin Awaiting requested review from ubruhin

Assignees
No one assigned
Labels
addition New library element. ready for review Waiting for review by maintainers.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbrgn @ubruhin