Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application interface's strings are appear in the wrong language #611

Closed
EdizonTN opened this issue Dec 1, 2019 · 1 comment · Fixed by #645
Closed

Application interface's strings are appear in the wrong language #611

EdizonTN opened this issue Dec 1, 2019 · 1 comment · Fixed by #645
Assignees
Labels
bug i18n / l10n Internationalization / Localization
Milestone

Comments

@EdizonTN
Copy link

EdizonTN commented Dec 1, 2019

VERSION / OS / ENVIRONMENT

LibrePCB Version: 0.1.3
Git Revision: 56bc60d
Build Date: 2019-11-30T21:59:40
Qt Version: 5.11.3 (built against 5.11.3)
CPU Architecture: x86_64
Operating System: Windows 7 SP 1 (6.1)
Platform Plugin: windows

SUMMARY

The application interface's strings are shown based on the OS System language settings. Libre PCB Workspace language settings are ignored (mostly).

STEPS TO REPRODUCE

OS Windows 7:
Change Regional settings to Slovak:

  1. Click the Start button, and then click Control Panel.
  2. Click Clock, Language, and Region, and then click Regional and Language Options.
  3. The Regional and Language Options dialog box appears. Change Format combo list value to Slovak.
    Lang_SysControlPanel

Now Start LibrePCB. Change Workspace setting -> Application Language to English and restart Libre PCB.

EXPECTED RESULTS

Of course, I should see interface strings, which depends on the workspace setting.

ACTUAL RESULTS

Lang_WorkspaceSettings

You can see result - some string are in Slovak (Most of them) - depends on OS's Regional settings and some in English (few strings) - depends on workspace setting.
Check also PCB Editor, Schematic Editor and Library Editor.
I think all strings are in Slovak - by OS Regional settings.

@EdizonTN EdizonTN changed the title Application interface's strings in appear in the wrong language Application interface's strings are appear in the wrong language Dec 1, 2019
@dbrgn dbrgn added bug i18n / l10n Internationalization / Localization labels Dec 1, 2019
@ubruhin
Copy link
Member

ubruhin commented Dec 1, 2019

Yeah I also noticed that some time ago... This happens because we always set the system language as fallback language for strings which aren't available in the language chosen in workspace settings. And since English contains almost no translations (it's the source language, so we don't need translations for it), most of the strings will fall back to the system language :(

@ubruhin ubruhin added this to the 0.1.4 milestone Dec 1, 2019
@ubruhin ubruhin self-assigned this Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n / l10n Internationalization / Localization
Development

Successfully merging a pull request may close this issue.

3 participants