Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store DRC settings in board file #1116

Merged
merged 2 commits into from Feb 28, 2023
Merged

Store DRC settings in board file #1116

merged 2 commits into from Feb 28, 2023

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Feb 27, 2023

Summary

This adds the DRC settings to the board file to make them persistent (see #669). Due to the needed refactoring, I also moved the settings from the DRC dialog into the new Board Setup dialog. As the DRC dialog is no longer useful, I removed it. The corresponding menu item / shortcut now opens the DRC dock widget and immediately executes the DRC instead of just opening the DRC dialog.

Note that the checkboxes to enable/disable each check individually have been removed as I think it makes no sense to store this information persistently. I'll open a PR soon to provide an alternative way to execute only parts of the checks.

File Format

 (design_rule_check
  (min_copper_width 0.2)
  (min_copper_copper_clearance 0.2)
  (min_copper_board_clearance 0.3)
  (min_copper_npth_clearance 0.2)
  (min_annular_ring 0.15)
  (min_npth_drill_diameter 0.25)
  (min_pth_drill_diameter 0.25)
  (min_npth_slot_width 1.0)
  (min_pth_slot_width 0.7)
  (allowed_npth_slots single_segment_straight)
  (allowed_pth_slots single_segment_straight)
 )

Screenshot

image

Closes #669

@ubruhin ubruhin added enhancement UI / UX User Interface/Experience file format Issues affecting the file format tool-board-editor labels Feb 27, 2023
@ubruhin ubruhin added this to the 0.2.0 milestone Feb 27, 2023
@ubruhin ubruhin self-assigned this Feb 27, 2023
@ubruhin ubruhin merged commit db443bb into master Feb 28, 2023
@ubruhin ubruhin deleted the 669-store-drc-settings branch February 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement file format Issues affecting the file format tool-board-editor UI / UX User Interface/Experience
Development

Successfully merging this pull request may close these issues.

Board editor: Save and restore DRC settings
1 participant