Factor out graphics code from core logic to editor logic #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
force-pushed
the
separate-graphics-from-logic
branch
3 times, most recently
from
8b881e1
to
8994b1e
Compare
ubruhin
force-pushed
the
separate-graphics-from-logic
branch
from
8994b1e
to
8e8e8da
Compare
ubruhin
force-pushed
the
separate-graphics-from-logic
branch
from
8e8e8da
to
e2179af
Compare
This was referenced Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A huge refactoring which finally creates a clear separation between core logic and graphics drawing code as requested a long time ago in #67. This means a lot of classes are moved from the
corelibrary into theeditorlibrary and are thus no longer contained in the CLI.Beside the cleaner software architecture, this decoupling gives us much higher flexibility regarding future editor features.
Closes #67.