Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Register *.lpp file extension #1145

Merged
merged 3 commits into from Apr 10, 2023
Merged

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Apr 8, 2023

This associates the *.lpp file extension on macOS with LibrePCB, done by adding the corresponding entries to the Info.plist file. Since this is not needed for the CLI, there are now two different Info.plist files.

Also fixed the ugly names of the mounted DMG volume and the application shortcut, now they are displayed as "LibrePCB".

Tested on macOS 11.7, seems to work fine so far. Unfortunately I needed to use the deprecated key CFBundleTypeExtensions because I was not able to get it working with the newer key LSItemContentTypes :-/

See also the related issue #1058.

@ubruhin ubruhin added enhancement deployment os-macos Issues affecting macOS labels Apr 8, 2023
@ubruhin ubruhin added this to the 1.0.0 milestone Apr 8, 2023
@ubruhin ubruhin self-assigned this Apr 8, 2023
@ubruhin ubruhin force-pushed the macos-register-file-extension branch 2 times, most recently from 9efe183 to ed93c70 Compare April 8, 2023 19:25
@ubruhin ubruhin force-pushed the macos-register-file-extension branch from ed93c70 to 4d59006 Compare April 8, 2023 20:43
@ubruhin ubruhin merged commit e1876af into master Apr 10, 2023
10 checks passed
@ubruhin ubruhin deleted the macos-register-file-extension branch April 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant