Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all libraries file format during background scan #1187

Merged
merged 4 commits into from Aug 10, 2023

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Aug 6, 2023

So far, libraries and their contained elements were not upgraded to the latest file format unless the user opened and saved them manually. Basically this works fine, but for long term it means there are lots of outdated files in the workspace which requires us to keep backwards compatibility forever. In addition , the background scan takes ages longer because it temporarily upgrades each element in memory before it can be added to the cache database.

To avoid these two problems, the background library scan now automatically upgrades any outdated library element in the workspace to the latest file format. This takes long on the first scan, but any further scan in massively faster then. In addition, it ensures that all files in the workspace are stored in the latest file format.

@ubruhin ubruhin added enhancement file format Issues affecting the file format labels Aug 6, 2023
@ubruhin ubruhin added this to the 1.0.0 milestone Aug 6, 2023
@ubruhin ubruhin self-assigned this Aug 6, 2023
@ubruhin ubruhin force-pushed the auto-upgrade-workspace-libraries branch from d42f036 to 089b520 Compare August 6, 2023 17:38
@ubruhin ubruhin force-pushed the auto-upgrade-workspace-libraries branch from 089b520 to 1f5ce3e Compare August 9, 2023 19:07
@ubruhin ubruhin merged commit 94e27f1 into master Aug 10, 2023
8 checks passed
@ubruhin ubruhin deleted the auto-upgrade-workspace-libraries branch August 10, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement file format Issues affecting the file format
Development

Successfully merging this pull request may close these issues.

None yet

1 participant