Board editor: Render pad & via texts with Fontobene #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the texts within pads and vias (pad number resp. net name) were drawn with a TrueType font, but it turned out this rendering was a huge performance bottleneck, slowing down the whole board editor on large designs. Now rendering them with a Fontobene stroke font which is much faster.
Really? 😂 🤦🏻 |
Yes, really 🙂 I never really experienced this problem on Linux, but on Windows it's a very serious issue. And now with this change, I realized it even slightly speeds up the board editor on Linux, pan/zoom feels completely instant now even with larger designs 💪 I don't know if there was some issue with our implementation of TrueType font rendering. Maybe there would be a solution to speed that up somehow, but replacing it by Fontobene was not a big deal and since it's a simple stroke font it's no surprise that performance is better... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the texts within pads and vias (pad number resp. net name) were drawn with a TrueType font, but it turned out this rendering was a huge performance bottleneck, slowing down the whole board editor on large designs. Especially on Windows the board editor became basically unusable (depending on zoom level).
Now rendering these texts with a Fontobene stroke font which is much faster.