Improve metainfo file

[Alexander-Wilms]

The URL types have been used according to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-url

I've removed the mention of the license from the list of features, since it's usually shown in a separate badge, like in KDE Discover or on [Flathub](https://flathub.org/apps/org.librepcb.LibrePCB):

Perhaps the mentioned innovative concepts could be expanded upon.

[ubruhin]

Looks great, thanks! Only a small whitespace issue which makes the stylecheck fail.

You can ignore the macOS CI failure, somehow it suddenly stopped working but it's not related to this PR 😭

[ubruhin]

I just saw there's a validation tool for this file and quickly run it:

$ appstream-util validate ./share/metainfo/org.librepcb.LibrePCB.metainfo.xml 
./share/metainfo/org.librepcb.LibrePCB.metainfo.xml: FAILED:
• tag-invalid           : <url> type invalid [unknown]
Validation of files failed

Any idea what's the exact problem? May it be related to the tool version?

$ appstream-util --version
Version:	0.7.18

[Alexander-Wilms]

Yes, I think these new URL types are not supported by older versions of appstream-util.
Cf. https://bugzilla.redhat.com/show_bug.cgi?id=1830923

The Flathub wiki suggests using the flatpak'd version:

$ flatpak install flathub org.freedesktop.appstream-glib
$ flatpak run org.freedesktop.appstream-glib validate share/metainfo/org.librepcb.LibrePCB.metainfo.xml
share/metainfo/org.librepcb.LibrePCB.metainfo.xml: OK
$ flatpak run org.freedesktop.appstream-glib validate-strict share/metainfo/org.librepcb.LibrePCB.metainfo.xml
share/metainfo/org.librepcb.LibrePCB.metainfo.xml: FAILED:
• tag-missing           : <update_contact> is not present
• value-missing         : <!-- Copyright [year] [name] --> is not present
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://github.com/LibrePCB/librepcb-doc/blob/b5488bb1dd8473d33110e744023e3ca14d796db1/about/img/screenshot.png?raw=true]
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://github.com/LibrePCB/librepcb-website/blob/5be4a16236c62ac587ead7d0d535d75d91c27f60/static/img/board_editor.png?raw=true]
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://github.com/LibrePCB/librepcb-website/blob/5be4a16236c62ac587ead7d0d535d75d91c27f60/static/img/control_panel.png?raw=true]
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://github.com/LibrePCB/librepcb-website/blob/5be4a16236c62ac587ead7d0d535d75d91c27f60/static/img/library_manager.png?raw=true]
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://github.com/LibrePCB/librepcb-website/blob/5be4a16236c62ac587ead7d0d535d75d91c27f60/static/img/schematic_editor.png?raw=true]
• translations-required  : <name> has no translations
• translations-required  : <summary> has no translations
• translations-required  : <description> has no translations
Validation of files failed

[ubruhin]

Alright, thanks for confirming!

Just to be sure, is this now ready from your side so it can be merged? Or do you intend to make more changes?

[Alexander-Wilms]

This set of changes is ready to be merged.

Perhaps newer screenshots showcasing the 1.0 GUI using a 16:9 aspect ratio could be added in a separate PR.