Heavily improve EAGLE library import #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
force-pushed
the
improve-eagle-library-import
branch
3 times, most recently
from
3db4118
to
91ae5ef
Compare
ubruhin
force-pushed
the
improve-eagle-library-import
branch
from
91ae5ef
to
6b33e6b
Compare
ubruhin
force-pushed
the
improve-eagle-library-import
branch
from
6b33e6b
to
43e9e93
Compare
ubruhin
force-pushed
the
improve-eagle-library-import
branch
from
43e9e93
to
d367647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1268, imported EAGLE library elements need to be much more accurate and respecting as many EAGLE properties as possible, otherwise we'll get too many problems in schematics and boards. Thus as a preparation, this PR heavily extends the EAGLE library import and fixes some issues:
The EAGLE parser has been extended accordingly in LibrePCB/parseagle#9.