Add new Windows installer based on Inno Setup #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
added
ci
deployment
os-windows
ubruhin
force-pushed
the
1256-new-installer
branch
2 times, most recently
from
dcbf73b
to
02acbdc
Compare
ubruhin
force-pushed
the
1256-new-installer
branch
from
02acbdc
to
476f956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the Qt5/x86 installer currently built with QtIFW, this PR also builds an installer for Qt6/x86_64 which is now based on Inno Setup. In contrast to the old online installer, this is an offline installer and allows silent install/uninstall from command line as required by package managers like Chocolatey or winget. For the complete evaluation process and more details, see #1256.
The intention is that for the next release both installers are provided, a QtIFW based installer for 32-bit and this new installer for 64-bit. Any following release will only be available for 64-bit and QtIFW will be removed from our build process. When running in GUI mode (non-silent), the new installer even detects an old installation and opens its uninstaller for a clean upgrade path.
Like the old installer, the new one also adds a startmenu entry and registers the file extensions
.lppand.lppz.Luckily I was able to get the installer version number extracted from the CMake project setup, so there's no need anymore to define the version number manually 馃檪
Built in the new Docker image created for Qt6 (LibrePCB/docker-librepcb-dev#35).
Tested on Windows 10 & 11.
Closes #1256