Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.2.0-unstable and add workspace migration #652

Merged
merged 12 commits into from Feb 5, 2020

Conversation

ubruhin
Copy link
Member

@ubruhin ubruhin commented Jan 8, 2020

To allow implementing file format changes, we need to bump the file format version to 0.2 and the application version to 0.2.0-unstable. But several other changes were needed in addition to just bumping the version:

Add "Initialize Workspace" wizard

If you open a workspace with LibrePCB 0.2.x the first time, a wizard now helps you to initialize/migrate the workspace to the new file format version:

grafik

When choosing a version to import from:

grafik

Or when choosing not to import any data:

grafik

Adjust first-run-wizard

Since the new wizard is now used to initialize a workspace, the "Settings" page was removed from the first-run-wizard. That wizard now only lets you choose the workspace, but does no longer initialize it.

Enable warning about unstable file format

From now on, the master branch must not be used for productive work since the file format is unstable. Thus the following warning now appears when starting an unstable version of LibrePCB:

grafik

Make CLI fail when trying to save files from unstable version

Same as in LibrePCB, it would be dangerous if files are saved with an unstable CLI version.


Since this is a very important change, it would be helpful to get some feedback!

@ubruhin ubruhin added the file format label Jan 8, 2020
@ubruhin ubruhin added this to the 0.2.0 milestone Jan 8, 2020
@ubruhin ubruhin self-assigned this Jan 8, 2020
@spookydd
Copy link

@spookydd spookydd commented Jan 8, 2020

Would it be helpful if I could also run this unstable version on mac?
Could it be run in parallel with the stable one?
I'm not doing any real project for now, so it's no trouble if something isn't working right, and if something does, then it's an opportunity to find out about it and then work on that.

@ubruhin
Copy link
Member Author

@ubruhin ubruhin commented Jan 11, 2020

@spookydd I'm not sure if we are talking about the same thing ;) This PR does not add any new "real" feature, it only bumps the version number and introduces a workspace migration wizard. This wizard is shown only the first time when opening a 0.1.x workspace, so it's only the migration itself which could be tested. But yes, of course you could test that migration if you like :)

@dbrgn
Copy link
Member

@dbrgn dbrgn commented Jan 12, 2020

Maybe I'll find time to do some testing on Sunday.

@ubruhin ubruhin merged commit 59f65e6 into master Feb 5, 2020
11 checks passed
@ubruhin ubruhin deleted the bump-file-format-version branch Feb 5, 2020
@ubruhin ubruhin mentioned this pull request Feb 5, 2020
@dbrgn
Copy link
Member

@dbrgn dbrgn commented Feb 6, 2020

Oh, sorry for not testing this, I totally forgot about the PR 🙂

I'll test it in the context of #510.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants