Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two separate configs #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

warmachinesocial
Copy link

Have added 2 xcschemes and xcconfigs file dev and prod such that makes file easier on env variables later down the road. Let me know if you're fine with it

…for running and testing out

At this stage, we can now begin to add env variable for dev and prod environment.
… the issue of dismiss view due to conflicts of keywords
@M3DZIK
Copy link
Member

M3DZIK commented Apr 6, 2024

@aeoliux

@M3DZIK
Copy link
Member

M3DZIK commented Apr 6, 2024

@warmachinesocial could you fix the build in github actions?

@warmachinesocial
Copy link
Author

@M3DZIK sorry forgot that my xcode automatically signs off, would just turn it off

@aeoliux
Copy link
Collaborator

aeoliux commented Apr 6, 2024

  1. GitHub Action fails (schemes were changed and xcodebuild does not recognize LibrePass scheme, look into Makefile)
  2. What is the purpose of custom environment? App works with custom API servers. You just need to specify one while creating account and logging in. Also no information about ${ROOT_URL} in Info.plist. There should be a default URL api.librepass.org .
  3. What is the purpose of xcschemes? Unsigned IPA is used for distribution. To test app on emulator you just need to run it and to test it on real device connected via USB cable choose development team and install it via Xcode.

@warmachinesocial
Copy link
Author

warmachinesocial commented Apr 7, 2024

  1. There are no env variables at this stage, however setting up from now to make life easier. In the case of following git flow with 3 branches(dev,staging,prod) we can just select specific xcsheme to automatically take the env variables from Info.plist.
  2. Hard coded values not good and ROOT_URL was just an example this case.
  3. Well I had my xcode by default on automatic signing with my ID therefore it threw the above error.
  4. Yes the build fails because I have removed(renamed) the old xcscheme and added new one also :- (LibrePass(Dev) and LibrePass(Prod)).
  5. Do we have a staging environment? Based on the code I think we just have 2 of them, correct me if I'm wrong

@aeoliux
Copy link
Collaborator

aeoliux commented Apr 7, 2024

We have only one branch and we don't need more

@warmachinesocial
Copy link
Author

No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants