Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor geocoding to use geopy instead #150

Closed
derneuere opened this issue Jan 25, 2021 · 5 comments
Closed

Refactor geocoding to use geopy instead #150

derneuere opened this issue Jan 25, 2021 · 5 comments
Labels
backend enhancement New feature or request

Comments

@derneuere
Copy link
Member

Geopy is a libary which has multiple reverse geocoding apis implemented. This could make our code simpler and more robust.
@derneuere derneuere added enhancement New feature or request backend labels Jan 25, 2021
@derneuere
Copy link
Member Author

Related to #143 and #9

@derneuere
Copy link
Member Author

I think this is the way to go. I will close the other tickets.

@derneuere
Copy link
Member Author

location.raw should have all the data we need:
https://towardsdatascience.com/things-to-do-with-latitude-longitude-data-using-geopy-python-1d356ed1ae30

@derneuere derneuere mentioned this issue Jul 7, 2022
Closed
@ThatCoffeeGuy ThatCoffeeGuy mentioned this issue Apr 26, 2023
Closed
@derneuere
Copy link
Member Author

This here looks also promising: https://photon.komoot.io/

@derneuere
Copy link
Member Author

This is now implemented, thanks to @sickelap :)

AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
@derneuere
Merge pull request LibrePhotos#150 from sickelap/settings_save_fix
2852091 
fix saving settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derneuere