Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write favorited / rating to photo metadata #310

Closed
jmalm opened this issue Aug 9, 2021 · 1 comment
Closed

Write favorited / rating to photo metadata #310

jmalm opened this issue Aug 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jmalm
Copy link
Contributor

jmalm commented Aug 9, 2021

Describe the enhancement you'd like
When a user marks a photo as favorited (or, in the future, sets a -1 - 5 rating), write this metadata back to the original photo or to an XMP sidecar file so that the information can be used in other software.

Describe why this will benefit the LibrePhotos
Photographers often use several applications as part of their own photography workflow. This enhancement will make it easier to use LibrePhotos as part of different workflows. For example, by feeding back favorited photos, LibrePhotos could be used for picking favorites to process in a separate photo editing software that has functionality for filtering photos based on metadata.

Additional context
I haven't found a good metadata tag for "favorited" photos that is supported by a wide range of photography software. In contrast, most have support for "rating". Because of this, LibrePhotos should base a "favorited" photo marking on "rating", with any photo with a rating greater than or equal to some user-defined minumum rating being regarded as "favorited". When a user marks a photo as "favorited", it should be given a rating equal to that user-defined minimum rating. (This will also make it possible to implement functionality for letting users set ratings, rather than just "favorited", in the future.)

Further, when the rating of a photo is changed, this should be written back as image metadata, either in the original image file, or as an XMP sidecar file. The reasoning for writing to an XMP sidecar file is that the user may not want LibrePhotos to modify the original file. Indeed, that file may even be read-only. Writing to the original image or an XMP sidecar file should be set by the user.

(Some of this work has already been started, but I wanted to create an issue to connect pull requests to, and also as a placeholder for discussions.)

@jmalm jmalm added the enhancement New feature or request label Aug 9, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Aug 9, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Aug 9, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Aug 10, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Aug 16, 2021
derneuere added a commit that referenced this issue Aug 16, 2021
#310: Use rating for favorited
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 2, 2021
… if present

Also, use only one exiftool instance per process.
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 3, 2021
… if present

Also, use only one exiftool instance per process.
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
… if present

Also, use only one exiftool instance per process.
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 4, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 7, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 9, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 10, 2021
jmalm pushed a commit to jmalm/librephotos that referenced this issue Sep 10, 2021
derneuere added a commit that referenced this issue Sep 12, 2021
@Michael2MacDonald
Copy link

It has been over a year, is there an update on this issue?

AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
…tadata_to_disk

-LibrePhotos#310: Let user configure save_metadata_to_disk
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
AnkurPrabhu pushed a commit to AnkurPrabhu/librephotos that referenced this issue Oct 22, 2023
-LibrePhotos#310: Update favorited photos in groups correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants