Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw images are not getting scanned #842

Closed
derneuere opened this issue May 2, 2023 · 14 comments
Closed

Raw images are not getting scanned #842

derneuere opened this issue May 2, 2023 · 14 comments
Assignees
Labels
backend bug Something isn't working

Comments

@derneuere
Copy link
Member

RAW images are not getting scanned on demo2. If you select the subfolder, it adds all the files to the scan, but then it will just skip them. This is either an ImageMagick issue or something that got introduced with live photos together.

@derneuere derneuere added the bug Something isn't working label May 2, 2023
@sickelap
Copy link
Contributor

sickelap commented May 3, 2023

Could you provide a sample photo to reproduce the issue?

@derneuere
Copy link
Member Author

librephotos.com/temp/testfiles.tar.gz

@sickelap
Copy link
Contributor

sickelap commented May 4, 2023

I was unable to reproduce the issue. I mapped the whole archive of sample photos and selected only raw folder to be used as data directory for the admin user.

Pulled fresh docker images

reallibrephotos/librephotos-frontend   latest    437252fd10d9   3 days ago     25.2MB
reallibrephotos/librephotos            latest    f7d7b6450655   3 days ago     5.36GB
reallibrephotos/librephotos-proxy      latest    67b51f6e41d4   3 days ago     142MB
reallibrephotos/librephotos-base       dev       362341297280   3 weeks ago    4.23GB

@derneuere
Copy link
Member Author

Thanks for looking into this :) @DigitalWarrior can you look into the server to maybe see what's up with the raw images? They are either missing or corrupted, I think

@DigitalWarrior
Copy link
Contributor

Will get it fixed.

@DigitalWarrior DigitalWarrior self-assigned this May 5, 2023
@DigitalWarrior
Copy link
Contributor

DigitalWarrior commented May 5, 2023

Getting errors on latest and dev.
The Scan finds them and reports 5 photos. Only one photo gets a thumbnail generated though the jpeg.
During the creation of the thumbnails the other file formats error out. "reason: no decode delegate for this image format"

Testing with 5 photos.
jpeg - Processed correctly
CR2 - Error
CR3 - Error
NEF - Error

Please see attached logs. This was done with photos on the server not uploaded though the web.

Logs
https://linx.librephotos.com/ownphotos.log
https://linx.librephotos.com/commandmigrate.log
https://linx.librephotos.com/gunicorndjango.log
https://linx.librephotos.com/gunicornimagesimilarity.log
https://linx.librephotos.com/imagesimilarity.log
https://linx.librephotos.com/rqworker.log
https://linx.librephotos.com/showmigrate.log

Photos
https://linx.librephotos.com/signatureeditsfreerawsdsc4437.nef
https://linx.librephotos.com/monica1903.cr2
https://linx.librephotos.com/img6316.cr2
https://linx.librephotos.com/img1627.jpg
https://linx.librephotos.com/img1302.cr3

@derneuere can you dig into the thumbnail generation?

@derneuere
Copy link
Member Author

The error is that ImageMagick can't find the correct deleagate, which is in this case libraw. We install libraw from source to get .cr3 support and that also used to work...

@derneuere derneuere changed the title Raw images are not getting scanned on demo2 Raw images are not getting scanned May 8, 2023
@derneuere
Copy link
Member Author

Cant reproduce the issue at the moment, because I get a different error. ImageMagick and Wand show that they support cr3, for example, but when I scan the process it hangs and never finishes.

@sickelap
Copy link
Contributor

Weird thing though is that the process hangs while generating the image here. Creating a test script to process any raw file within the backend container is successful.

root@27b92a8a2bec:/data# ls IMG_1811.*
IMG_1811.CR3
root@27b92a8a2bec:/data# cat test.py 
#!/usr/bin/env python
from wand.image import Image
with Image(filename="./IMG_1811.CR3") as img:
    with img.clone() as thumbnail:
        thumbnail.save(filename="./IMG_1811.webp")
root@27b92a8a2bec:/data# ./test.py
root@27b92a8a2bec:/data# ls IMG_1811.*
IMG_1811.CR3  IMG_1811.webp

@sickelap
Copy link
Contributor

There are other issues related to managing model data, but that's not related to this one.

@derneuere
Copy link
Member Author

It could be an issue like this one here, but I am not sure yet: emcconville/wand#536

@sickelap
Copy link
Contributor

hah, interesting. I'll play around with it...

@sickelap
Copy link
Contributor

#854 should fix this

@derneuere
Copy link
Member Author

It's now fixed thanks to #854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants