-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support motion photos #813
Conversation
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("api", "0041_apply_user_enum_for_person"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have a couple of other migrations, which means, that this line needs to be updated
I would prefer it if we could maintain consistency in how we save technical files for LibrePhotos. "embedded_media" files are extracted in the folder where the original file lives. This breaks the regular pattern where we save needed files in the protected_media folder. I think adding a folder named embedded_media and saving embedded_media there would make the most sense. I think there are also a couple of changes needed for calculating the thumbnails. The thumbnail in the list is probably a video and the big thumbnail an image. We also would need a new type of live / motion photos, which you could then add to PigSerializer. I am looking forward to your frontend pull request! |
SonarCloud Quality Gate failed.
|
I totally agree with embedded media location. As those are not primary files but rather extracted from the original, it makes sense to keep them in a private location. In fact, this was bugging me too. Now, extracted media files will be placed into the I don't think that messing with thumbnails is necessary because of what I have in mind for the frontend. |
Alright, looking forward to the frontend pr :) |
This adds support for parsing and extracting video from Google Pixel and Samsung motion photos.
Sample photo attached to #797 did not have XMP metadata and exiftool was unable to parse it. Parsing manually does pretty good job. Extracted videos are added as
embedded_media
property fromPhoto.main_file
.Adding support for
HEIF
/HEIC
(a.k.a. Apple Live Photos) is more involved, but hopefully we will have it done as well in the future.PR for frontend will follow