Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin scikit-learn #905

Merged
merged 1 commit into from
Jul 1, 2023
Merged

pin scikit-learn #905

merged 1 commit into from
Jul 1, 2023

Conversation

crutcha
Copy link
Contributor

@crutcha crutcha commented Jul 1, 2023

The backend container for librephotos-docker is throwing an exception on startup:

  File "/usr/local/lib/python3.11/dist-packages/hdbscan/hdbscan_.py", line 40, in <module>
    FAST_METRICS = KDTree.valid_metrics + BallTree.valid_metrics + ["cosine", "arccos"]
                   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for +: 'builtin_function_or_method' and 'builtin_function_or_method'

It looks like this is due to a bug introduced in a newer version of scikit-learn: scikit-learn-contrib/hdbscan#597

If I pin scikit-learn, the container starts successfully.

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derneuere
Copy link
Member

Thanks for looking in to the issue! Looks good to me.

@derneuere derneuere merged commit 1bb831e into LibrePhotos:dev Jul 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants