Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISP integration - 'internet' topology link too dependant for tree #307

Closed
syadnom opened this issue Mar 28, 2023 · 1 comment
Closed

UISP integration - 'internet' topology link too dependant for tree #307

syadnom opened this issue Mar 28, 2023 · 1 comment
Milestone

Comments

@syadnom
Copy link

syadnom commented Mar 28, 2023

Excuse the ambiguous title.
Using UISP integration.
2 sites have links in UISP to 'internet'.
EdgeA>SiteA1>A2>A3...
EdgeB>SiteB1>B2>B3

running the integration, network.json creates 2 trees under the root. One for EdgeA and one for EdgeB.

Site A2 does not exist in the tree from EdgeB.

This isn't desirable. If EdgeB goes down and traffic begins to flow out EdgeA, that shaper tree and path isn't used. EdgeB exists in EdgeA's networks.json but as a top level node.

It would be preferrable I think for most if not all installs if the 'internet' links in UISP that are NOT at the root site are ignored.

So EdgeA would have an entire complete network tree for all sites so if traffic does end up coming in there, it's in the tree. Same for EdgeB.

If I remove internet links in UISP for EdgeB, then the integration builds the tree I want. But I need those links in there because UISP wont build the map if they aren't there. Also, the integration builds a tree starting from the internet connected (UISP's line to internet...) so deleting those 'internet' lines in UISP isn't a hack to make this work.

@rchac rchac pinned this issue Mar 31, 2023
@rchac rchac added this to the v1.4 milestone Mar 31, 2023
@rchac
Copy link
Member

rchac commented Apr 11, 2023

Let us know if this pull helps #328

@dtaht dtaht modified the milestones: v1.4, v1.5 Beta Mar 14, 2024
@rchac rchac closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants