add secondary networks in UISP integration to shapers for non-nat, routed subnets

[syadnom]

right now, UISP integration seems to only pull in the first matching IP on a device and ignores the rest. This is probably ok normally BUT if you have a routed subnet at the device, it's not shaped and there's no real way to get that into UISP other than put it as a subnet in an interface. UISP wont let you add a second device with the subnet, it'll only take a single IP.

For examble, 'other' device, 100.70.10.15 is the CPE, that's entered in to UISP and so UISP integration pulls that in perfectly.
now add 100.80.10.0/24 to a second interface. This doesn't show up in Shaped devices.

I propose that if a secondary IP subnet matches and it's the 'network' address, ie 100.80.10.0/24 then add that subnet into shapers.

[thebracket]

I like this conceptually (and I can think of a few places it'd help me!), would probably have to be an option. I know Dave fought hard to make the network address usable and not special - so he may have something to say about this?

…

On Wed, Nov 22, 2023, 8:56 PM syadnom ***@***.***> wrote: right now, UISP integration seems to only pull in the first matching IP on a device and ignores the rest. This is probably ok normally BUT if you have a routed subnet at the device, it's not shaped and there's no real way to get that into UISP other than put it as a subnet in an interface. UISP wont let you add a second device with the subnet, it'll only take a single IP. For examble, 'other' device, 100.70.10.15 is the CPE, that's entered in to UISP and so UISP integration pulls that in perfectly. now add 100.80.10.0/24 to a second interface. This doesn't show up in Shaped devices. I propose that if a secondary IP subnet matches and it's the 'network' address, ie 100.80.10.*0*/24 then add that subnet into shapers. — Reply to this email directly, view it on GitHub <#425>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRU43ZWAGQK62FZ4P66MELYF23NRAVCNFSM6AAAAAA7XDYOBCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDONBQGQZDANY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>