Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rocket_async_compression to latest version #368

Closed
wants to merge 1 commit into from
Closed

Upgrade rocket_async_compression to latest version #368

wants to merge 1 commit into from

Conversation

Ameobea
Copy link

@Ameobea Ameobea commented Jun 27, 2023

  • Latest version has some fixes that can avoid extremely slow compression in some cases as well as other improvements

@Ameobea
Upgrade rocket_async_compression to latest version
434f807 
 * Latest version has some fixes that can avoid extremely slow compression in some cases as well as other improvements
@thebracket thebracket changed the base branch from main to develop May 17, 2024 16:40
@thebracket thebracket self-requested a review May 17, 2024 16:41
@thebracket thebracket added the enhancement New feature or request label May 17, 2024
@thebracket thebracket added this to the v1.5 Beta milestone May 17, 2024
@thebracket thebracket self-assigned this May 30, 2024
@thebracket
Copy link
Collaborator

I should've done this earlier, I'm running into some merge issues when I try to test it locally (rather bizarre ones). Since it's really a one-liner (updating Cargo.toml, and letting the lock file update), I'm going to make a secondary PR and put Amoeba in as a Co-Authored-By ( https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors ).

thebracket added a commit that referenced this pull request May 31, 2024
@thebracket
CLOSES ISSUE #368
380ae55 
Co-authored-by: Casey Primozic <me@ameo.link>

* Update Rocket Async Compression to version 0.6
* Update Rocket to Version 0.5.1

No substantive changes and it works as before, but the compression is faster.
@thebracket thebracket mentioned this pull request May 31, 2024
Merged
@thebracket thebracket closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebracket thebracket Awaiting requested review from thebracket

Assignees

@thebracket thebracket

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.5 Beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ameobea @thebracket